runtime/trace: stub more functions #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
reviewed
Oct 31, 2024
src/runtime/trace/trace.go
Outdated
|
|
||
| func Logf(ctx context.Context, category, format string, args ...any) {} | ||
|
|
||
| func WithRegion(ctx context.Context, regionType string, fn func()) {} |
There was a problem hiding this comment.
I don't think this is correct. The documentation says:
WithRegion starts a region associated with its calling goroutine, runs fn, and then ends the region.
So even if we don't implement tracing, I think WithRegion should at least call fn.
There was a problem hiding this comment.
Good call, I've adjusted the function to call the passed in fn, thanks!
joonas
force-pushed
the
runtime/trace-stub-more-functions
branch
from
2ab77f1
to
1852997
Compare
Signed-off-by: Joonas Bergius <[email protected]>
joonas
force-pushed
the
runtime/trace-stub-more-functions
branch
from
1852997
to
82d45f2
Compare
|
Force push seems to have done the trick 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across the following error while I was looking at using the opentelemetry libraries with TinyGo:
I thought it would be nice to have these functions stubbed out so that it would be possible to get further along with libraries that might try to make use of these
runtime/tracefunctions, if for no other reason than to be able to use thego:linknamedirective to do something else with them.